Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/slow stop #77

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Feat/slow stop #77

merged 7 commits into from
Sep 13, 2023

Conversation

tkhmy
Copy link
Contributor

@tkhmy tkhmy commented Sep 1, 2023

Related Issue(required)

Description(required)

  • add slow stop view

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
@tkhmy tkhmy requested a review from yabuta September 1, 2023 06:10
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Signed-off-by: tkhmy <[email protected]>
Copy link
Collaborator

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkhmy tkhmy merged commit 8d20711 into develop Sep 13, 2023
1 of 2 checks passed
@tkhmy tkhmy deleted the feat/slow_stop branch September 13, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants